Closed
Conversation
added 3 commits
April 27, 2021 15:37
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
chapulina
approved these changes
Jul 19, 2021
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
I haven't tried building with Bazel but I took a high-level look and nothing seemed strange
BUILD.bazel
Outdated
|
|
||
| PROJECT_MAJOR = 7 | ||
|
|
||
| PROJECT_MINOR = 0 |
Contributor
There was a problem hiding this comment.
Suggested change
| PROJECT_MINOR = 0 | |
| PROJECT_MINOR = 1 |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Adds build infrastructure for Bazel in ign-msgs7
Test it
Follow instructions on setting up the bazel build environment from https://github.com/ignitionrobotics/ign-bazel
Then:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge