Pose, twist and odometry with covariance msgs#224
Conversation
Signed-off-by: Aditya <aditya050995@gmail.com>
Codecov Report
@@ Coverage Diff @@
## ign-msgs8 #224 +/- ##
==========================================
Coverage 85.38% 85.38%
==========================================
Files 9 9
Lines 951 951
==========================================
Hits 812 812
Misses 139 139 Continue to review full report at Codecov.
|
Signed-off-by: Aditya <aditya050995@gmail.com>
|
actually, have you tested whether the ros_ign bridge properly converts this to the corresponding ROS message? |
|
I'd rather not merge this to a stable branch if it hasn't been tested with the bridge |
|
I haven't tested it with the |
Signed-off-by: Aditya <aditya050995@gmail.com>
jacobperron
left a comment
There was a problem hiding this comment.
LGTM, one question about style below.
Signed-off-by: Aditya <aditya050995@gmail.com>
03af435 to
0426e8b
Compare
Signed-off-by: Aditya <aditya050995@gmail.com>
6e226d8 to
1b70880
Compare
Signed-off-by: Aditya <aditya050995@gmail.com>
4eec69f to
9d33ded
Compare
|
PR to bridge these msgs to ROS : gazebosim/ros_gz#222 |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1 |
Signed-off-by: Aditya aditya050995@gmail.com
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Summary
This PR adds 2 new message types :
TwistWithCovarianceandPoseWithCovariancewhich have covariance matrices along with the original twist / pose message. This type was available ingeometry_msgs/*WithCovarianceand was used ingazebo_ros_pkgsin cases where the poses have noise associated with them.Also fixes a minor typo in
twist.protoChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸