Skip to content

Remove Bionic from future releases (Garden+)#229

Merged
chapulina merged 1 commit intomainfrom
chapulina/main/rm/bionic
Mar 11, 2022
Merged

Remove Bionic from future releases (Garden+)#229
chapulina merged 1 commit intomainfrom
chapulina/main/rm/bionic

Conversation

@chapulina
Copy link
Contributor

Summary

ign-msgs9 will be on Garden.

Test it

No Bionic builds should be triggered.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added documentation Improvements or additions to documentation tests Broken or missing tests / testing infra labels Mar 11, 2022
@chapulina chapulina requested a review from caguero as a code owner March 11, 2022 19:31
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #229 (bb465b4) into main (8462930) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files           9        9           
  Lines         956      956           
=======================================
  Hits          817      817           
  Misses        139      139           
Impacted Files Coverage Δ
src/Utility.cc 82.28% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8462930...bb465b4. Read the comment docs.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 11, 2022
@chapulina
Copy link
Contributor Author

I cancelled the Windows build because the buildfarm is swamped and that shouldn't be affected by this PR. I think this is good to go!

Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chapulina chapulina merged commit 12b1593 into main Mar 11, 2022
@chapulina chapulina deleted the chapulina/main/rm/bionic branch March 11, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation 🌱 garden Ignition Garden tests Broken or missing tests / testing infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants