Skip to content

Added visualize_visual to light.proto#248

Merged
ahcorde merged 1 commit intomainfrom
ahcorde/light/visual
Apr 20, 2022
Merged

Added visualize_visual to light.proto#248
ahcorde merged 1 commit intomainfrom
ahcorde/light/visual

Conversation

@ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 19, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina April 19, 2022 21:22
@ahcorde ahcorde requested a review from caguero as a code owner April 19, 2022 21:22
@ahcorde ahcorde self-assigned this Apr 19, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #248 (2522c63) into main (d0bf413) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2522c63 differs from pull request most recent head 1592558. Consider uploading reports for the commit 1592558 to get more accurate results

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   15.91%   15.90%   -0.01%     
==========================================
  Files         382      382              
  Lines       71391    71409      +18     
==========================================
  Hits        11361    11361              
- Misses      60030    60048      +18     
Impacted Files Coverage Δ
include/ignition/msgs/light.pb.cc 10.92% <0.00%> (-0.30%) ⬇️
include/ignition/msgs/light.pb.h 1.49% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0bf413...1592558. Read the comment docs.

@ahcorde ahcorde merged commit e61edda into main Apr 20, 2022
@ahcorde ahcorde deleted the ahcorde/light/visual branch April 20, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants