ign -> gz Namespace Migration : gz-msgs by methylDragon · Pull Request #252 · gazebosim/gz-msgs

methylDragon · 2022-05-18T05:37:42Z

Note: The include/gz/msgs redirection headers point to ignition and use the ignition namespace, that's why they need the config.hh to support the namespace remaps in downstream packages.

Signed-off-by: methylDragon <methylDragon@gmail.com>

include/gz/msgs/actor.pb.h

include/ignition/msgs/config.hh

Signed-off-by: methylDragon <methylDragon@gmail.com>

Migrating ignition.msgs -> gz.msgs leads to a change in index for splitting any input string. This fixes a failing test. Signed-off-by: methylDragon <methylDragon@gmail.com>

Signed-off-by: methylDragon <methylDragon@gmail.com>

chapulina

I believe we should be able to tick-tock headers and namespaces. The only thing we haven't found a way of tick-tocking is custom message generation. Most Gazebo libraries and external users don't create custom messages though, so I think it's worth at least tick-tocking headers and namespaces.

I tried these small changes on top of your branches:

namespace_migration...chapulina/namespace_migration
- Add ignition redirection headers for the generated protobuf (only did one msg as a POC)
- Add namespace alias with pragma warning
gazebosim/gz-transport@namespace_migration...chapulina/namespace_migration
- Changed one place on ign-transport to include the old header and use the old namespace.
- The test compiles with a warning, and passes.

What do you think?

CMakeLists.txt

include/ignition/msgs/Factory.hh

Signed-off-by: methylDragon <methylDragon@gmail.com>

methylDragon · 2022-05-25T05:50:03Z

Migration updated accordingly: e99f08a

include/ignition/msgs/SuppressWarning.hh

test/integration/deprecated_TEST.cc

CMakeLists.txt

src/CMakeLists.txt

chapulina · 2022-05-25T19:47:53Z

Oh yeah, and because so many files are being moved, we'll need a clean commit history to rebase-merge here. 🙃

Signed-off-by: methylDragon <methylDragon@gmail.com>

methylDragon · 2022-05-25T20:47:05Z

Oh yeah, and because so many files are being moved, we'll need a clean commit history to rebase-merge here. upside_down_face

The files being moved here are the redirection headers added in the header migration, do we need to preserve the history for those (there's no history aside from that single commit)?

Signed-off-by: methylDragon <methylDragon@gmail.com>

Signed-off-by: methylDragon <methylDragon@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org>

chapulina

The files being moved here are the redirection headers added in the header migration, do we need to preserve the history for those (there's no history aside from that single commit)?

Ah fair point, we can squash merge this PR then!

LGTM with 🟢 CI

Signed-off-by: Louise Poubel <louise@openrobotics.org>

codecov · 2022-05-28T20:52:11Z

Codecov Report

Merging #252 (976c405) into main (03a7434) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   15.90%   15.90%           
=======================================
  Files         382      382           
  Lines       71409    71409           
=======================================
  Hits        11361    11361           
  Misses      60048    60048

Impacted Files	Coverage Δ
include/ignition/msgs/statistic.pb.cc
include/ignition/msgs/wireless_nodes.pb.cc
include/ignition/msgs/discovery.pb.cc
include/ignition/msgs/request.pb.cc
include/ignition/msgs/projector.pb.cc
include/ignition/msgs/model_configuration.pb.cc
include/ignition/msgs/rest_post.pb.cc
include/ignition/msgs/camera_cmd.pb.cc
include/ignition/msgs/log_playback_control.pb.cc
include/ignition/msgs/physics.pb.cc
... and 563 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a7434...976c405. Read the comment docs.

methylDragon added 2 commits May 17, 2022 22:27

Update header guards

e65187a

Signed-off-by: methylDragon <methylDragon@gmail.com>

Migrate namespaces

075201e

Signed-off-by: methylDragon <methylDragon@gmail.com>

methylDragon requested a review from caguero as a code owner May 18, 2022 05:37

github-actions bot added the 🌱 garden Ignition Garden label May 18, 2022

methylDragon added 4 commits May 17, 2022 22:39

Add migration line

383554a

Signed-off-by: methylDragon <methylDragon@gmail.com>

Add deprecation test

92974b6

Signed-off-by: methylDragon <methylDragon@gmail.com>

Implement deprecation trick

47586c0

Signed-off-by: methylDragon <methylDragon@gmail.com>

Include config.hh, even for gz

5a2d05f

Signed-off-by: methylDragon <methylDragon@gmail.com>

methylDragon force-pushed the namespace_migration branch from 84839de to 5a2d05f Compare May 18, 2022 05:39

methylDragon mentioned this pull request May 18, 2022

C++ namespaces, directories and header guards from ignition to gz gazebo-tooling/release-tools#711

Closed

chapulina added ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library labels May 18, 2022

chapulina reviewed May 18, 2022

View reviewed changes

include/gz/msgs/actor.pb.h Show resolved Hide resolved

include/ignition/msgs/config.hh Outdated Show resolved Hide resolved

methylDragon added 7 commits May 19, 2022 13:50

Use pragma deprecation message instead

1c7fca0

Signed-off-by: methylDragon <methylDragon@gmail.com>

Ticktock config macros

4f0bc56

Signed-off-by: methylDragon <methylDragon@gmail.com>

Comment out pragma message for msgs

12e8641

Signed-off-by: methylDragon <methylDragon@gmail.com>

Migrate inline namespaces

8179e70

Signed-off-by: methylDragon <methylDragon@gmail.com>

Mention gz headers in migration

9f4e527

Signed-off-by: methylDragon <methylDragon@gmail.com>

Update config.hh

dd9a33b

Signed-off-by: methylDragon <methylDragon@gmail.com>

Update Export.hh macros and the deprecated test

48e2543

Signed-off-by: methylDragon <methylDragon@gmail.com>

methylDragon force-pushed the namespace_migration branch 6 times, most recently from d675836 to 7955b00 Compare May 20, 2022 07:55

Hard-tock to gz

12033d2

Signed-off-by: methylDragon <methylDragon@gmail.com>

methylDragon force-pushed the namespace_migration branch from 7955b00 to 12033d2 Compare May 20, 2022 08:32

methylDragon added 2 commits May 20, 2022 03:41

Migrate github links

ac5199e

Signed-off-by: methylDragon <methylDragon@gmail.com>

Migrate user-facing Ignition to Gazebo

47b4672

Signed-off-by: methylDragon <methylDragon@gmail.com>

methylDragon added 7 commits May 20, 2022 05:40

Migrate gz-common logging calls

5ea5adc

Signed-off-by: methylDragon <methylDragon@gmail.com>

Fix substring bug in Factory

82162a5

Migrating ignition.msgs -> gz.msgs leads to a change in index for splitting any input string. This fixes a failing test. Signed-off-by: methylDragon <methylDragon@gmail.com>

Fix header guard for test_config

20be54e

Signed-off-by: methylDragon <methylDragon@gmail.com>

Gazebo Robotics -> Gazebo

ba85136

Signed-off-by: methylDragon <methylDragon@gmail.com>

ignitionrobotics -> gazebosim

c85a8ca

Signed-off-by: methylDragon <methylDragon@gmail.com>

Revert migration for fuel.ignitionrobotics.org

e1bd261

Signed-off-by: methylDragon <methylDragon@gmail.com>

Rollback osrf-migration.github.io migrations

195f907

Signed-off-by: methylDragon <methylDragon@gmail.com>

chapulina suggested changes May 25, 2022

View reviewed changes

CMakeLists.txt Show resolved Hide resolved

include/ignition/msgs/Factory.hh Show resolved Hide resolved

methylDragon added 3 commits May 24, 2022 22:38

Add redirection headers for ignition and deprecated test

483d95f

Signed-off-by: methylDragon <methylDragon@gmail.com>

Tick-tock (INSTALL_)IGN_MSGS_GEN_EXECUTABLE

ac94016

Signed-off-by: methylDragon <methylDragon@gmail.com>

Update migration

e99f08a

Signed-off-by: methylDragon <methylDragon@gmail.com>

chapulina suggested changes May 25, 2022

View reviewed changes

include/ignition/msgs/SuppressWarning.hh Show resolved Hide resolved

test/integration/deprecated_TEST.cc Show resolved Hide resolved

CMakeLists.txt Show resolved Hide resolved

src/CMakeLists.txt Outdated Show resolved Hide resolved

src/CMakeLists.txt Show resolved Hide resolved

Add SuppressWarning.hh back in

9566553

Signed-off-by: methylDragon <methylDragon@gmail.com>

Update CMakeLists.txt

f536320

Signed-off-by: methylDragon <methylDragon@gmail.com>

methylDragon force-pushed the namespace_migration branch from 7245abe to f536320 Compare May 25, 2022 20:48

"Use" Factory in deprecated_TEST

2e80a90

Signed-off-by: methylDragon <methylDragon@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org>

chapulina approved these changes May 26, 2022

View reviewed changes

fix deprecation close

976c405

Signed-off-by: Louise Poubel <louise@openrobotics.org>

chapulina merged commit 2770d34 into main May 28, 2022

chapulina deleted the namespace_migration branch May 28, 2022 21:06

chapulina removed the needs upstream release Blocked by a release of an upstream library label May 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ign -> gz Namespace Migration : gz-msgs#252

ign -> gz Namespace Migration : gz-msgs#252
chapulina merged 30 commits intomainfrom
namespace_migration

methylDragon commented May 18, 2022

Uh oh!

Uh oh!

Uh oh!

chapulina left a comment

Uh oh!

Uh oh!

Uh oh!

methylDragon commented May 25, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chapulina commented May 25, 2022

Uh oh!

methylDragon commented May 25, 2022 •

edited

Loading

Uh oh!

chapulina left a comment

Uh oh!

codecov bot commented May 28, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

methylDragon commented May 18, 2022

Uh oh!

Uh oh!

Uh oh!

chapulina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

methylDragon commented May 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chapulina commented May 25, 2022

Uh oh!

methylDragon commented May 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chapulina left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

methylDragon commented May 25, 2022 •

edited

Loading

methylDragon commented May 25, 2022 •

edited

Loading

codecov bot commented May 28, 2022 •

edited

Loading