Conversation
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-msgs5 #254 +/- ##
==============================================
+ Coverage 12.93% 85.27% +72.33%
==============================================
Files 346 9 -337
Lines 60130 903 -59227
==============================================
- Hits 7779 770 -7009
+ Misses 52351 133 -52218 Continue to review full report at Codecov.
|
18 tasks
ahcorde
requested changes
May 24, 2022
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
ahcorde
approved these changes
Jun 7, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
approved these changes
Jun 14, 2022
Contributor
chapulina
left a comment
There was a problem hiding this comment.
LGTM! Pushed 385141e with some final tweaks:
- Always install CLI files, see #166 and gazebo-tooling/release-tools#472
- Link against filesystem to fix Bionic build
Member
|
I think the debian metadata needs to be updated to install the new completion files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of gazebosim/gz-tools#1
Used together with gazebosim/gz-tools#87
Summary
Bash completion, installation, tests.
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.