Skip to content

Bash completion for flags#254

Merged
chapulina merged 6 commits intoign-msgs5from
mabelzhang/tab_completion
Jun 14, 2022
Merged

Bash completion for flags#254
chapulina merged 6 commits intoign-msgs5from
mabelzhang/tab_completion

Conversation

@mabelzhang
Copy link
Contributor

@mabelzhang mabelzhang commented May 21, 2022

🎉 New feature

Part of gazebosim/gz-tools#1
Used together with gazebosim/gz-tools#87

Summary

Bash completion, installation, tests.

Test it

$ . install/share/gz/gz.completion
$ ign msg -     
--force-version  --info           --versions       -i
--help           --list           -h               -l

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang mabelzhang added the OOBE 📦✨ Out-of-box experience label May 21, 2022
@mabelzhang mabelzhang requested a review from chapulina May 21, 2022 04:58
@mabelzhang mabelzhang requested a review from caguero as a code owner May 21, 2022 04:58
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels May 21, 2022
@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #254 (385141e) into ign-msgs5 (57458eb) will increase coverage by 72.33%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           ign-msgs5     #254       +/-   ##
==============================================
+ Coverage      12.93%   85.27%   +72.33%     
==============================================
  Files            346        9      -337     
  Lines          60130      903    -59227     
==============================================
- Hits            7779      770     -7009     
+ Misses         52351      133    -52218     
Impacted Files Coverage Δ
include/ignition/msgs/gps_sensor.pb.cc
include/ignition/msgs/magnetometer_sensor.pb.h
include/ignition/msgs/test.pb.cc
include/ignition/msgs/heightmapgeom.pb.h
include/ignition/msgs/pose.pb.cc
include/ignition/msgs/camera_lens.pb.h
include/ignition/msgs/vector2d.pb.h
include/ignition/msgs/undo_redo.pb.cc
include/ignition/msgs/color.pb.h
include/ignition/msgs/camera_info.pb.h
... and 345 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57458eb...385141e. Read the comment docs.

@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label May 23, 2022
@chapulina chapulina requested a review from ahcorde May 23, 2022 16:58
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pushed 385141e with some final tweaks:

@chapulina chapulina enabled auto-merge (squash) June 14, 2022 23:33
@chapulina chapulina merged commit 97ea6f5 into ign-msgs5 Jun 14, 2022
@chapulina chapulina deleted the mabelzhang/tab_completion branch June 14, 2022 23:42
@scpeters
Copy link
Member

I think the debian metadata needs to be updated to install the new completion files

dh_missing: warning: usr/share/gz/gz1.completion.d/msgs5.bash_completion.sh exists in debian/tmp but is not installed to anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 needs upstream release Blocked by a release of an upstream library OOBE 📦✨ Out-of-box experience

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants