Skip to content

Update GoogleTest to latest version#257

Merged
mjcarroll merged 6 commits intomainfrom
bump_gtest
Jun 28, 2022
Merged

Update GoogleTest to latest version#257
mjcarroll merged 6 commits intomainfrom
bump_gtest

Conversation

@mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented May 31, 2022

Import latest version of GoogleTest from upstream and adjust build accordingly.

Signed-off-by: Michael Carroll michael@openrobotics.org

@mjcarroll mjcarroll requested a review from caguero as a code owner May 31, 2022 15:39
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #257 (d8cb0e5) into main (14f6fd3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   14.53%   14.53%           
=======================================
  Files         200      200           
  Lines       12505    12505           
=======================================
  Hits         1817     1817           
  Misses      10688    10688           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f6fd3...d8cb0e5. Read the comment docs.

@chapulina chapulina added the tests Broken or missing tests / testing infra label Jun 6, 2022
@chapulina
Copy link
Contributor

Homebrew is unhappy:

/Users/jenkins/workspace/ignition_msgs-ci-pr_any-homebrew-amd64/ign-msgs/test/gtest/include/gtest/internal/gtest-port.h:844:12: error: no member named 'make_tuple' in namespace 'std'
using std::make_tuple;
      ~~~~~^

@mjcarroll
Copy link
Contributor Author

Homebrew is unhappy:

I think we aren't correctly setting c++17 for ign-msgs.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll merged commit 7cf04fc into main Jun 28, 2022
@mjcarroll mjcarroll deleted the bump_gtest branch June 28, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden tests Broken or missing tests / testing infra

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants