Skip to content

ign -> gz Upstream Macro Migration : gz-msgs#260

Merged
methylDragon merged 12 commits intomainfrom
macro_migration
Jun 17, 2022
Merged

ign -> gz Upstream Macro Migration : gz-msgs#260
methylDragon merged 12 commits intomainfrom
macro_migration

Conversation

@methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from caguero as a code owner June 6, 2022 23:08
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 6, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 6, 2022
@chapulina chapulina self-requested a review June 6, 2022 23:54
@chapulina chapulina changed the base branch from main to env_var_migration June 7, 2022 02:01
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once upstream is merged.

@methylDragon methylDragon force-pushed the macro_migration branch 2 times, most recently from 2f1c5ae to f082c02 Compare June 7, 2022 21:28
Base automatically changed from env_var_migration to main June 8, 2022 04:03
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 15, 2022
methylDragon and others added 12 commits June 17, 2022 11:20
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #260 (a9f55c6) into main (e240db2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   14.53%   14.53%           
=======================================
  Files         200      200           
  Lines       12505    12505           
=======================================
  Hits         1817     1817           
  Misses      10688    10688           
Impacted Files Coverage Δ
include/gz/msgs/Factory.hh 100.00% <ø> (ø)
src/Generator.cc 92.53% <100.00%> (ø)
src/Utility.cc 82.28% <100.00%> (ø)
src/ign.cc 90.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e240db2...a9f55c6. Read the comment docs.

@methylDragon methylDragon merged commit f82e2e5 into main Jun 17, 2022
@methylDragon methylDragon deleted the macro_migration branch June 17, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants