[ign to gz] Factory::New accept ignition with warning#281
Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
methylDragon
approved these changes
Jul 19, 2022
Contributor
methylDragon
left a comment
methylDragon
left a comment
There was a problem hiding this comment.
Provisionally approving if the comment I left earlier can be disregarded :o
Codecov Report
@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 85.59% 84.62% -0.98%
==========================================
Files 10 10
Lines 972 995 +23
==========================================
+ Hits 832 842 +10
- Misses 140 153 +13
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
methylDragon
requested changes
Jul 21, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: methylDragon <methylDragon@gmail.com>
methylDragon
approved these changes
Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignitiontogzgazebo-tooling/release-tools#711Summary
Accept
ignitionmessages onFactory::New, print warning and returngzequivalent.Test it
Try sending an
ignitionmessage, see that it's sent, and a warning is printed.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸