Conversation
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
github-actions
bot
added
Gazebo 1️1️
Codecov Report
@@ Coverage Diff @@
## ign-msgs5 #283 +/- ##
==============================================
+ Coverage 85.27% 97.12% +11.85%
==============================================
Files 9 9
Lines 903 905 +2
==============================================
+ Hits 770 879 +109
+ Misses 133 26 -107
Continue to review full report at Codecov.
|
chapulina
suggested changes
Jul 22, 2022
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
Great to see the coverage efforts resulting in implementation improvements 😃
chapulina
approved these changes
Jul 22, 2022
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
LGTM, I'll leave it up to you if you think the nitpick is worth addressing.
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of gazebosim/gz-sim#1575
Summary
Utility.cccoverage by adding tests forConvertFuelMetadatamethodsConvertFuelMetadata(string, msgs::FuelMetadata)function to take care of<world>: a1d294d (commit message is backwards 😅)splitfunction: 8ff8356Test it
./path/to/build/UNIT_Utility_TEST --gtest_filter="*ConvertFuelMetadata"Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.