Skip to content

Merge ign-msgs4 ➡️ ign-msgs5#287

Merged
chapulina merged 5 commits intoign-msgs5from
chapulina/4_to_5
Jul 28, 2022
Merged

Merge ign-msgs4 ➡️ ign-msgs5#287
chapulina merged 5 commits intoign-msgs5from
chapulina/4_to_5

Conversation

@chapulina
Copy link
Contributor

@chapulina chapulina commented Jul 28, 2022

➡️ Forward port

Port ign-msgs4 ➡️ ign-msgs5

Branch comparision: ign-msgs5...ign-msgs4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

nkoenig and others added 5 commits July 22, 2022 21:39
@nkoenig @chapulina
Change IGN_DESIGNATION to GZ_DESIGNATION (#282)
7bdc58c 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Remove mistaken VERSION (#284)
6f992e5 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Merge branch 'ign-msgs3' into 3-4-designation
29593f8
@chapulina
3 ➡️ 4 (#286)
ad498d1 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
4 ➡️ 5
21f7f5d 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from caguero as a code owner July 28, 2022 16:25
@chapulina chapulina requested a review from nkoenig July 28, 2022 16:26
@chapulina chapulina enabled auto-merge July 28, 2022 16:26
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #287 (afb2bd5) into ign-msgs5 (b344d98) will not change coverage.
The diff coverage is n/a.

❗ Current head afb2bd5 differs from pull request most recent head 21f7f5d. Consider uploading reports for the commit 21f7f5d to get more accurate results

@@            Coverage Diff             @@
##           ign-msgs5     #287   +/-   ##
==========================================
  Coverage      97.12%   97.12%           
==========================================
  Files              9        9           
  Lines            905      905           
==========================================
  Hits             879      879           
  Misses            26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b344d98...21f7f5d. Read the comment docs.

@chapulina chapulina merged commit 1715173 into ign-msgs5 Jul 28, 2022
@chapulina chapulina deleted the chapulina/4_to_5 branch July 28, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkoenig nkoenig nkoenig approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees

No one assigned

Labels

🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chapulina @nkoenig @osrf-triage