ParemeterError: rename NO_ERROR to SUCCESS

[ivanpauno]

🦟 Bug fix

Fixes gazebosim/gz-transport#305 (comment).

Summary

To avoid conflicts with winerror.h macro.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #298 (ad030ce) into ign-msgs8 (61607f9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           ign-msgs8     #298   +/-   ##
==========================================
  Coverage      96.64%   96.64%           
==========================================
  Files              9        9           
  Lines            953      953           
==========================================
  Hits             921      921           
  Misses            32       32           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[scpeters]

testing with gz-transport in gazebosim/gz-transport#349 using the following commits:

• gazebosim/gz-transport@8ffcfd6
• gazebo-tooling/gazebodistro@c3dd97a
  • https://build.osrfoundation.org/job/ign_transport-pr-win/341/
• osrf/homebrew-simulation@a88134e
  • https://build.osrfoundation.org/job/ignition_transport-ci-pr_any-homebrew-amd64/1374/

[scpeters]

ABI checker failure is expected and ok since these changes have not yet been released