Added cubemap_uri to sky

[nkoenig]

🎉 New feature

Summary

Added a cubemap_uri string to the sky.proto message, which supports gazebosim/sdformat#1037.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[mjcarroll]

Test failures look to be unrelated. Any chance you would want to address them here or is this time-critical?

[mjcarroll]

Actually, is this supposed to be targeting main or gz-msgs9

[nkoenig]

This is suppose to target main because msgs9 has already been released. I could squint my eyes and sneak this into gz-msgs9. It technically breaks API, but I doubt anyone has used gz-msgs9 in the last couple hours.

[mabelzhang]

Test failures look to be unrelated (bash completion flags).
This is time critical for end of the week.

[mabelzhang]

Wait, we're doing skybox for Fortress, which is still on msgs8 right?

[nkoenig]

This is not needed for the skybox work. The skybox work uses the header map in the sky message. This is here to replace that method in the future.

[nkoenig]

Waiting on gz-sim7 to main forward port.

[codecov]

Codecov Report

Merging #306 (236ccab) into main (5d00d2a) will not change coverage.
The diff coverage is n/a.

❗ Current head 236ccab differs from pull request most recent head b69c696. Consider uploading reports for the commit b69c696 to get more accurate results

@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files           9        9           
  Lines        1073     1073           
=======================================
  Hits         1027     1027           
  Misses         46       46