Skip to content

Disable Focal on Harmonic#363

Merged
azeey merged 3 commits intomainfrom
azeey/ci_harmonic
Jul 26, 2023
Merged

Disable Focal on Harmonic#363
azeey merged 3 commits intomainfrom
azeey/ci_harmonic

Conversation

@azeey
Copy link

@azeey azeey commented Jul 17, 2023

🎉 New feature

Summary

Harmonic only supports Jammy so removing Focal CI.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from caguero as a code owner July 17, 2023 23:39
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 17, 2023
@azeey azeey enabled auto-merge (squash) July 20, 2023 20:33
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey disabled auto-merge July 21, 2023 04:55
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #363 (48383e4) into main (572f59b) will increase coverage by 0.27%.
The diff coverage is n/a.

❗ Current head 48383e4 differs from pull request most recent head ee12391. Consider uploading reports for the commit ee12391 to get more accurate results

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   95.43%   95.71%   +0.27%     
==========================================
  Files          10        9       -1     
  Lines        1030     1073      +43     
==========================================
+ Hits          983     1027      +44     
+ Misses         47       46       -1     

see 7 files with indirect coverage changes

@azeey
Copy link
Author

azeey commented Jul 21, 2023

@mjcarroll I've disabled doxygen for autogenerated protobuf files in ee12391. The generation used to work somewhat in ign-msgs8 (https://gazebosim.org/api/msgs/8/namespaceignition_1_1msgs.html), but seems to be broken in gz-msgs9 because the generated files are now in the details namespace and our doxygen configuration ignores that namespace. I don't think it's worth the effort to generate docs since the API is documented in https://protobuf.dev/reference/cpp/api-docs/

@azeey azeey merged commit 5d00d2a into main Jul 26, 2023
@azeey azeey deleted the azeey/ci_harmonic branch July 26, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants