Skip to content

Fix installation path of __init__.py#364

Merged
azeey merged 1 commit intogazebosim:mainfrom
azeey:fix_python_debs
Jul 19, 2023
Merged

Fix installation path of __init__.py#364
azeey merged 1 commit intogazebosim:mainfrom
azeey:fix_python_debs

Conversation

@azeey
Copy link

@azeey azeey commented Jul 18, 2023

🦟 Bug fix

Summary

__init__.py was not being installed to the proper directory if USE_SYSTEM_PATHS_FOR_PYTHON_INSTALLATION was set.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from Voldivh July 18, 2023 23:10
@azeey azeey requested a review from caguero as a code owner July 18, 2023 23:10
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #364 (b7d2a3b) into main (4372e74) will not change coverage.
The diff coverage is n/a.

❗ Current head b7d2a3b differs from pull request most recent head 3183819. Consider uploading reports for the commit 3183819 to get more accurate results

@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files          10       10           
  Lines        1030     1030           
=======================================
  Hits          983      983           
  Misses         47       47           

@azeey azeey merged commit 572f59b into gazebosim:main Jul 19, 2023
@azeey azeey deleted the fix_python_debs branch July 19, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants