Improve message generation tutorial and example#386
Merged
Conversation
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
This was referenced Sep 25, 2023
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Codecov Report
@@ Coverage Diff @@
## gz-msgs10 #386 +/- ##
==========================================
Coverage 97.26% 97.26%
==========================================
Files 27 27
Lines 1170 1170
==========================================
Hits 1138 1138
Misses 32 32 |
added 2 commits
September 27, 2023 16:10
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
|
I've added the new file to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the example, and adds some more documentation about how message generation works in a tutorial.
While there is some duplication between them, I think there is value in having the tutorial, as those are what gets indexed in the documentation as well as coverage in the tutorial party. I think there is value in having the example as that gets CI coverage.