Ensure that tests pass fine with GZ_RELOCATABLE_INSTALL option enabled#394
Merged
mjcarroll merged 2 commits intogazebosim:gz-msgs10from Nov 7, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## gz-msgs10 #394 +/- ##
==========================================
Coverage 97.67% 97.67%
==========================================
Files 27 27
Lines 1163 1163
==========================================
Hits 1136 1136
Misses 27 27 |
Contributor
|
Friendly ping @traversaro, if this is ready I can review. |
Contributor
Author
Ok! For the DCO should I rebased on the latest gz-msgs10 dropping the merge and adding the DCO just on the latest rebased commit? |
Contributor
Rebasing generally fixes it, but I can also override it as I have done here, since it's the merge commit causing the issue. |
mjcarroll
approved these changes
Nov 7, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fix tests when GZ_RELOCATABLE_INSTALL CMake option is enabled and the operating system is Windows or Linux without the install step being run.
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.