Skip to content

Bazel updates for Harmonic#397

Merged
mjcarroll merged 26 commits intogz-msgs10from
mjcarroll/bazel_harmonic
Apr 5, 2024
Merged

Bazel updates for Harmonic#397
mjcarroll merged 26 commits intogz-msgs10from
mjcarroll/bazel_harmonic

Conversation

@mjcarroll
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 12, 2023
@mjcarroll mjcarroll force-pushed the mjcarroll/bazel_harmonic branch from 6c5875b to 78146c1 Compare October 12, 2023 20:10
@mjcarroll mjcarroll self-assigned this Oct 13, 2023
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll force-pushed the mjcarroll/bazel_harmonic branch from 78146c1 to 4795e34 Compare February 6, 2024 02:42
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll marked this pull request as ready for review March 4, 2024 19:21
@mjcarroll mjcarroll requested a review from caguero as a code owner March 4, 2024 19:21
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@codecov
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.19%. Comparing base (5f90910) to head (bb61343).

Additional details and impacted files
@@            Coverage Diff             @@
##           gz-msgs10     #397   +/-   ##
==========================================
  Coverage      98.19%   98.19%           
==========================================
  Files             27       27           
  Lines           1166     1166           
==========================================
  Hits            1145     1145           
  Misses            21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mjcarroll added 12 commits March 4, 2024 19:44
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjcarroll , how can we test it?

@mjcarroll mjcarroll marked this pull request as draft March 8, 2024 19:56
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Copy link
Contributor Author

@caguero CI running here: gazebosim/gz-bazel#75

@mjcarroll mjcarroll marked this pull request as ready for review March 14, 2024 15:37
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll force-pushed the mjcarroll/bazel_harmonic branch from 4964687 to 317d704 Compare April 1, 2024 23:10
deps = [
":gzmsgs_proto",
"@com_google_protobuf//:any_proto",
"@com_google_protobuf//:protobuf",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add @com_google_protobuf//:any_cc_proto to deps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's not a target in this version of protobuf:

$ bazel query "@com_google_protobuf//:*"
@com_google_protobuf//:BUILD
@com_google_protobuf//:any_proto
@com_google_protobuf//:api_proto
@com_google_protobuf//:cc_test_protos_genproto
@com_google_protobuf//:cc_toolchain
@com_google_protobuf//:cc_wkt_protos
@com_google_protobuf//:cc_wkt_protos_genproto
@com_google_protobuf//:compiler_plugin_proto
@com_google_protobuf//:descriptor_proto
@com_google_protobuf//:duration_proto
@com_google_protobuf//:empty_proto
@com_google_protobuf//:field_mask_proto
@com_google_protobuf//:java_toolchain
@com_google_protobuf//:javalite_toolchain
@com_google_protobuf//:linux-aarch64
@com_google_protobuf//:linux-ppc
@com_google_protobuf//:linux-s390x
@com_google_protobuf//:linux-x86_32
@com_google_protobuf//:linux-x86_64
@com_google_protobuf//:macos-aarch64
@com_google_protobuf//:macos-x86_64
@com_google_protobuf//:objectivec
@com_google_protobuf//:protobuf
@com_google_protobuf//:protobuf_headers
@com_google_protobuf//:protobuf_java
@com_google_protobuf//:protobuf_java_util
@com_google_protobuf//:protobuf_javalite
@com_google_protobuf//:protobuf_lite
@com_google_protobuf//:protobuf_objc
@com_google_protobuf//:protobuf_python
@com_google_protobuf//:protobuf_python_genproto
@com_google_protobuf//:protoc
@com_google_protobuf//:protoc_lib
@com_google_protobuf//:python_common_test_protos_genproto
@com_google_protobuf//:python_specific_test_protos_genproto
@com_google_protobuf//:source_context_proto
@com_google_protobuf//:struct_proto
@com_google_protobuf//:timestamp_proto
@com_google_protobuf//:type_proto
@com_google_protobuf//:well_known_type_protos
@com_google_protobuf//:windows-x86_32
@com_google_protobuf//:windows-x86_64
@com_google_protobuf//:wrappers_proto

@mjcarroll mjcarroll merged commit 1f080a4 into gz-msgs10 Apr 5, 2024
@mjcarroll mjcarroll deleted the mjcarroll/bazel_harmonic branch April 5, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants