Skip to content

Miscellaneous housekeeping#398

Merged
mjcarroll merged 3 commits intogz-msgs10from
mjcarroll/cleanup_msgs10
Oct 13, 2023
Merged

Miscellaneous housekeeping#398
mjcarroll merged 3 commits intogz-msgs10from
mjcarroll/cleanup_msgs10

Conversation

@mjcarroll
Copy link
Contributor

  • Remove unused bazel file
  • Remove/rename unused headers
  • All the factory to read from multiple locations.

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll requested a review from caguero as a code owner October 12, 2023 14:26
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #398 (7c73127) into gz-msgs10 (0622409) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7c73127 differs from pull request most recent head 18bf943. Consider uploading reports for the commit 18bf943 to get more accurate results

@@            Coverage Diff             @@
##           gz-msgs10     #398   +/-   ##
==========================================
  Coverage      97.26%   97.26%           
==========================================
  Files             27       27           
  Lines           1170     1172    +2     
==========================================
+ Hits            1138     1140    +2     
  Misses            32       32           
Files Coverage Δ
core/include/gz/msgs/convert/Pose.hh 100.00% <ø> (ø)
core/src/DynamicFactory.cc 86.76% <100.00%> (+0.40%) ⬆️

@mjcarroll mjcarroll self-assigned this Oct 13, 2023
@mjcarroll mjcarroll merged commit edd9632 into gz-msgs10 Oct 13, 2023
@mjcarroll mjcarroll deleted the mjcarroll/cleanup_msgs10 branch October 13, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants