Skip to content

Update material_color to use Entity.#415

Merged
azeey merged 1 commit intogazebosim:gz-msgs10from
rudislabs:pr-matcol-add-entity
Jan 17, 2024
Merged

Update material_color to use Entity.#415
azeey merged 1 commit intogazebosim:gz-msgs10from
rudislabs:pr-matcol-add-entity

Conversation

@bperseghetti
Copy link
Member

@bperseghetti bperseghetti commented Jan 16, 2024

🦟 Bug fix

Summary

Use preferred method of Entity instead of name and parent_name

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@bperseghetti bperseghetti requested a review from caguero as a code owner January 16, 2024 23:26
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 16, 2024
@codecov
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce3ccb9) 97.67% compared to head (65c8985) 97.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           gz-msgs10     #415   +/-   ##
==========================================
  Coverage      97.67%   97.67%           
==========================================
  Files             27       27           
  Lines           1163     1163           
==========================================
  Hits            1136     1136           
  Misses            27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment

Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
@bperseghetti bperseghetti requested a review from azeey January 17, 2024 00:06
@azeey azeey merged commit 35a267f into gazebosim:gz-msgs10 Jan 17, 2024
@bperseghetti bperseghetti deleted the pr-matcol-add-entity branch January 17, 2024 01:50
bperseghetti added a commit to rudislabs/gz-msgs that referenced this pull request Mar 27, 2024
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants