Merged
Conversation
Levi-Armstrong
force-pushed
the
feature/ConeMsg
branch
from
859b18d to
7e2622f
Compare
iche033
reviewed
May 4, 2020
Contributor
iche033
left a comment
iche033
left a comment
There was a problem hiding this comment.
looks good to me. Just one minor comment
proto/ignition/msgs/conegeom.proto
Outdated
| @@ -0,0 +1,36 @@ | |||
| /* | |||
| * Copyright (C) 2017 Open Source Robotics Foundation | |||
Contributor
There was a problem hiding this comment.
can you update the year to 2020?
Contributor
|
can you sign off your commit? We are now requiring this for DCO check to pass. You can click on Details beside |
Levi-Armstrong
force-pushed
the
feature/ConeMsg
branch
2 times, most recently
from
9d1c6ed to
e2ffa57
Compare
iche033
approved these changes
May 5, 2020
chapulina
approved these changes
May 6, 2020
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR.
My only comment is about documentation. We've been trying to at least document the new messages.
Levi-Armstrong
force-pushed
the
feature/ConeMsg
branch
from
e2ffa57 to
ec8f802
Compare
Signed-off-by: Levi Armstrong <levi.armstrong@gmail.com>
Levi-Armstrong
force-pushed
the
feature/ConeMsg
branch
from
ec8f802 to
2d471b7
Compare
chapulina
approved these changes
May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.