Add rule to build python version of protos#474
Merged
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-msgs10 #474 +/- ##
=============================================
+ Coverage 98.19% 98.21% +0.01%
=============================================
Files 27 27
Lines 1166 1174 +8
=============================================
+ Hits 1145 1153 +8
Misses 21 21 ☔ View full report in Codecov by Sentry. |
mjcarroll
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Depends on gazebosim/gz-bazel#77
Summary
Add rule in bazel build file to build python version of proto files
Test it
Setup up gz-bazel worksspace, update to
update_rules_python_versionbranch (see gazebosim/gz-bazel#77) and build:Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.