Use /bigobj in MSVC to support protobuf 3.12 library (#56)#57
Merged
chapulina merged 1 commit intogazebosim:masterfrom May 18, 2020
Merged
Use /bigobj in MSVC to support protobuf 3.12 library (#56)#57chapulina merged 1 commit intogazebosim:masterfrom
/bigobj in MSVC to support protobuf 3.12 library (#56)#57chapulina merged 1 commit intogazebosim:masterfrom
Conversation
Contributor
|
Thanks Josef for the PR! Would you mind following the instructions on the DCO bot https://github.com/ignitionrobotics/ign-msgs/pull/57/checks?check_run_id=685922380 to have the commit signed off? |
j-rivero
approved these changes
May 18, 2020
Contributor
j-rivero
left a comment
j-rivero
left a comment
There was a problem hiding this comment.
I can not find any downsides or tradeoffs of the activation of bigobj.
Signed-off-by: Jozef Izso <jozef.izso@gmail.com>
jozefizso
force-pushed
the
dev/protobuf_3.12_fix
branch
from
9d40e48 to
979d6cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56