Fix unused result warnings (backport #570)#574
Merged
Conversation
Contributor
Author
|
Cherry-pick of 60b4f77 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
11 tasks
Check that protobuf return codes are successful. DynamicFactory: check FindAllMessageNames result --------- Signed-off-by: Steve Peters <scpeters@intrinsic.ai> (cherry picked from commit 60b4f77)
25d5534 to
9812803
Compare
scpeters
approved these changes
Mar 11, 2026
Member
|
this backport fixes 5 of 6 warnings There is still a warning at Factory.cc:254 that was fixed in gz-msgs10 and newer by #384 |
Member
|
I'll merge for now with these fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes compiler warnings, related to gazebosim/gz-transport#810
Summary
As noted in the protobuf 34.0 release notes
[[nodiscard]]has been added to many APIs, which is causing severalunused-resultcompiler warnings in this package:This fixes the warnings in test code in 9005375 and in DynamicFactory in 12f2f82
Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.
This is an automatic backport of pull request #570 done by [Mergify](https://mergify.com).