Skip to content

Fix unused result warnings (backport #570)#574

Merged
scpeters merged 1 commit intoign-msgs8from
mergify/bp/ign-msgs8/pr-570
Mar 11, 2026
Merged

Fix unused result warnings (backport #570)#574
scpeters merged 1 commit intoign-msgs8from
mergify/bp/ign-msgs8/pr-570

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 11, 2026

🦟 Bug fix

Fixes compiler warnings, related to gazebosim/gz-transport#810

Summary

As noted in the protobuf 34.0 release notes [[nodiscard]] has been added to many APIs, which is causing several unused-result compiler warnings in this package:

This fixes the warnings in test code in 9005375 and in DynamicFactory in 12f2f82

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.


This is an automatic backport of pull request #570 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from caguero as a code owner March 11, 2026 20:10
@mergify mergify bot added the conflicts label Mar 11, 2026
@mergify
Copy link
Contributor Author

mergify bot commented Mar 11, 2026

Cherry-pick of 60b4f77 has failed:

On branch mergify/bp/ign-msgs8/pr-570
Your branch is up to date with 'origin/ign-msgs8'.

You are currently cherry-picking commit 60b4f77.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   test/integration/headers.cc

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   core/src/DynamicFactory.cc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 11, 2026
@mergify mergify bot mentioned this pull request Mar 11, 2026
11 tasks
Check that protobuf return codes are successful.
DynamicFactory: check FindAllMessageNames result

---------

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
(cherry picked from commit 60b4f77)
@scpeters scpeters force-pushed the mergify/bp/ign-msgs8/pr-570 branch from 25d5534 to 9812803 Compare March 11, 2026 20:17
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Mar 11, 2026
@scpeters
Copy link
Member

this backport fixes 5 of 6 warnings

There is still a warning at Factory.cc:254 that was fixed in gz-msgs10 and newer by #384

@scpeters
Copy link
Member

I'll merge for now with these fixes

@scpeters scpeters merged commit 10c691b into ign-msgs8 Mar 11, 2026
8 of 9 checks passed
@scpeters scpeters deleted the mergify/bp/ign-msgs8/pr-570 branch March 11, 2026 21:47
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant