Convert functions between duration and ignition::time#85
Merged
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 85.83% 85.85% +0.01%
==========================================
Files 7 7
Lines 805 806 +1
==========================================
+ Hits 691 692 +1
Misses 114 114
Continue to review full report at Codecov.
|
chapulina
approved these changes
Sep 14, 2020
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
I think we could keep the old functions, but since this is ready to go I don't think it needs to change. I'd just ask that the style comment below be fixed before merging 😉
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the PR gazebosim/gz-sensors#41 (comment) makes sense to use
durationinstead oftime_point, This function will convert secs and nanoseconds tostd::chrono::steady_clock::durationThis PR is part of this issue gazebosim/gz-common#61.
Signed-off-by: ahcorde ahcorde@gmail.com