Add dependency conversion for model.config's#91
Merged
Conversation
added 2 commits
October 6, 2020 22:44
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-msgs5 #91 +/- ##
=============================================
- Coverage 85.66% 84.38% -1.28%
=============================================
Files 7 7
Lines 795 807 +12
=============================================
Hits 681 681
- Misses 114 126 +12
Continue to review full report at Codecov.
|
Signed-off-by: John Shepherd <john@openrobotics.org>
caguero
approved these changes
Oct 21, 2020
Collaborator
caguero
left a comment
caguero
left a comment
There was a problem hiding this comment.
Looks reasonable to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a conversion to get all of the dependencies from a
model.config, not sure if it's desired since we're transitioning towardsmetadata.pbtxt, but since somemodel.config's already have dependencies listed in thedependtag and for the sake of testing, I decided to make this PR, we can cancel it if it is not desired.