Skip to content

Resolve updated codecheck issues#96

Merged
chapulina merged 1 commit intoign-msgs4from
adlarkin/cpplint_fixes
Nov 4, 2020
Merged

Resolve updated codecheck issues#96
chapulina merged 1 commit intoign-msgs4from
adlarkin/cpplint_fixes

Conversation

@adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Nov 4, 2020

This PR is meant to resolve new codecheck issues introduced by gazebosim/gz-cmake#117.

From my understanding, the plan is to forward port the fixes here to all other ignition versions once gazebosim/gz-cmake#117 is merged.

Signed-off-by: Ashton Larkin ashton@openrobotics.org

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@adlarkin adlarkin requested a review from caguero as a code owner November 4, 2020 01:25
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Nov 4, 2020
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #96 into ign-msgs4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs4      #96   +/-   ##
==========================================
  Coverage      96.21%   96.21%           
==========================================
  Files              7        7           
  Lines            608      608           
==========================================
  Hits             585      585           
  Misses            23       23           
Impacted Files Coverage Δ
src/ign.cc 90.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e703bd...f273ebb. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chapulina chapulina merged commit 8b88f80 into ign-msgs4 Nov 4, 2020
@chapulina chapulina deleted the adlarkin/cpplint_fixes branch November 4, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📜 blueprint Ignition Blueprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants