Merged
Conversation
Signed-off-by: Dre Westcook <dre.west@outlook.com>
Signed-off-by: Dre Westcook <dre.west@outlook.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
added
enhancement
Closed
chapulina
added
the
needs upstream release
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
9 tasks
Signed-off-by: Louise Poubel <louise@openrobotics.org>
9 tasks
jennuine
reviewed
Dec 29, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This was referenced Jan 4, 2022
Merged
chapulina
removed
the
needs upstream release
Signed-off-by: Louise Poubel <louise@openrobotics.org>
adlarkin
reviewed
Jan 7, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1248 +/- ##
=============================================
Coverage 61.97% 61.97%
=============================================
Files 276 278 +2
Lines 23000 23106 +106
=============================================
+ Hits 14254 14321 +67
- Misses 8746 8785 +39
Continue to review full report at Codecov.
|
adlarkin
approved these changes
Jan 11, 2022
Contributor
adlarkin
left a comment
adlarkin
left a comment
There was a problem hiding this comment.
Looks great! I left one comment if you wouldn't mind taking a look before merging.
Signed-off-by: Louise Poubel <louise@openrobotics.org>
7 tasks
Signed-off-by: Louise Poubel <louise@openrobotics.org>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of
Supersedes
Requires
Summary
The fork for the original PR (#519) has been removed, so I can't push changes to that PR. I kept @Dotrar's commits in this branch.
I retargeted this PR from Dome to Fortress because the GPS sensor will need to use spherical coordinates (see #981).
Test it
ign gazebo spherical_coordinates.sdfign topic -e -t /navsatTODO
[GUI] [Err] [Conversions.cc:1103] Attempting to convert a NavSat SDF sensor, but the sensor pointer is null.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸