New service for adding systems to an entity#1524
Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
…ign-gazebo into server-config-root-dom
…bo into use_sdf_plugin
Signed-off-by: Nate Koenig <nate@openrobotics.org>
…bo into use_sdf_plugin
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
chapulina
left a comment
There was a problem hiding this comment.
Did a first pass, the functionality works for me. Tested manually like this, for some fun results:
ign gazebo shapes.sdf -v 4 -r &
ign service -s /world/shapes/entity/system/add --reqtype ignition.msgs.EntityPlugin_V --reptype ignition.msgs.Boolean --timeout 3000 --req 'entity: {id: 1}, plugins: {name: "ignition::gazebo::systems::Buoyancy", filename: "ignition-gazebo-buoyancy-system"}'
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
f3f340b to
1e22d2c
Compare
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
a05f06b to
4695b88
Compare
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
There was a problem hiding this comment.
LGTM, let's just wait for #1352 to be merged first.
We also need an ign-msgs8 release with gazebosim/gz-msgs#261, I started a forward-port so we get more into the release: gazebosim/gz-msgs#264
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1524 +/- ##
============================================
Coverage 63.96% 63.96%
============================================
Files 317 317
Lines 25584 25613 +29
============================================
+ Hits 16364 16383 +19
- Misses 9220 9230 +10
Continue to review full report at Codecov.
|
🎉 New feature
Summary
Adds a service for adding systems / plugins to an entity at run time. The service accepts the new
EntityPlugin_V.protomsg introduced in gazebosim/gz-msgs#261 that contains the entity id and an array of plugins / systems to add to the entity.Test it
Run the
INTEGRATION_entity_systemtest. It adds thediff_driveplugin to a vehicle model and verifies that it starts moving after the plugin is added.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.