Conversation
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
|
Nice!
Since this is something that won't be needed by all packages, I'm leaning towards leaving it here. |
Wait, come to think of it, most packages have a So now I think we could use some Ruby linting for most libraries. I guess the difficulty will be to put it in a common place to reduce duplication. Sort of how we have |
chapulina
left a comment
There was a problem hiding this comment.
This looks good to me as is, I'll leave it up to you if you think it could be moved to a common place.
Integrate
rubocopas the ruby style checker.@chapulina, @j-rivero, should we move the
rubocopdependency from here tohttps://github.com/ignition-tooling/action-ignition-ci/blob/master/entrypoint.shdirectly?