Skip to content

Add ruby style checker#25

Merged
caguero merged 4 commits intoign-tools1from
caguero/ruby_style
Aug 6, 2020
Merged

Add ruby style checker#25
caguero merged 4 commits intoign-tools1from
caguero/ruby_style

Conversation

@caguero
Copy link
Contributor

@caguero caguero commented Aug 5, 2020

Integrate rubocop as the ruby style checker.

@chapulina, @j-rivero, should we move the rubocop dependency from here to https://github.com/ignition-tooling/action-ignition-ci/blob/master/entrypoint.sh directly?

caguero added 3 commits August 5, 2020 21:33
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero requested a review from chapulina August 5, 2020 20:10
Base automatically changed from chapulina/0_to_1 to ign-tools1 August 5, 2020 21:47
@chapulina
Copy link
Contributor

Nice!

should we move the rubocop dependency from here to https://github.com/ignition-tooling/action-ignition-ci/blob/master/entrypoint.sh directly?

Since this is something that won't be needed by all packages, I'm leaning towards leaving it here.

@chapulina
Copy link
Contributor

Since this is something that won't be needed by all packages,

Wait, come to think of it, most packages have a cmd<lib>.rb file that could be linted too 😏 And ign-math has more and more Ruby files too.

So now I think we could use some Ruby linting for most libraries. I guess the difficulty will be to put it in a common place to reduce duplication. Sort of how we have make codecheck on ign-cmake (which wouldn't help ign-tools...).

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as is, I'll leave it up to you if you think it could be moved to a common place.

@caguero caguero merged commit 6c6ed6a into ign-tools1 Aug 6, 2020
@caguero caguero deleted the caguero/ruby_style branch August 6, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants