fix: Use PACKAGE_PREFIX_DIR to ensure relocatable CMake install for conan#30
Merged
caguero merged 1 commit intogazebosim:ign-tools1from Nov 20, 2020
Merged
Conversation
github-actions
bot
added
🏢 edifice
Pro
force-pushed
the
cmake-relocatable
branch
from
ebc18d9 to
26977fd
Compare
This was referenced Nov 17, 2020
…onan Signed-off-by: Stefan Profanter <stefan.profanter@agile-robots.com>
Pro
force-pushed
the
cmake-relocatable
branch
from
26977fd to
fd72ad9
Compare
Contributor
|
Note that the change in the |
Contributor
|
Thanks @traversaro! @j-rivero , do you foresee any issues? |
Member
I made that comment on dartsim, and yes I think it will break our |
|
@scpeters Consider using the trick used in dartsim/dart#1529. It should work even for the case you described. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using CMAKE_INSTALL_PREFIX causes build issues when you relocate the installed CMake package, i.e., as it is done in conan.
CMAKE_INSTALL_PREFIX should not be used in the cmake.in files directly. The
@PACKAGE_INIT@macro initializesPACKAGE_PREFIX_DIRcorrespondingly.See also:
gazebosim/gz-cmake#129
gazebosim/sdformat#419
gazebosim/gazebo-classic#2782
cc @stefanbuettner