Remove ruby find_program and ronn. Not really used#53
Merged
j-rivero merged 5 commits intoign-tools1from Jun 23, 2021
Merged
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
github-actions
bot
added
🏢 edifice
added 2 commits
June 19, 2021 22:33
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
ahcorde
approved these changes
Jun 21, 2021
chapulina
approved these changes
Jun 21, 2021
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
LGTM, I think we can also remove ruby-ronn from the README?
Contributor
Author
done! thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Issue fix
Summary
The build process is not using ruby or ruby-ronn at all. Remove it from CMake.
Checklist
Note to maintainers: Remember to use Squash-Merge