Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This was referenced Jun 21, 2022
methylDragon
approved these changes
Jun 23, 2022
This was referenced Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Requires
Summary
Reduce duplication with other Gazebo libraries by depending on
gz-cmake.There's been a previous attempt at migrating to
gz-cmakein PR 6, but at the time we decided against it because it would be complicated to support two versions installing theignexecutable. With the move togz(see gazebo-tooling/release-tools#739), that's no longer an issue.Test it
gz-plugin, and check that thegz pluginCLI workscolcon testand check thatUNIT_gz_TESTandrubocoppassedcolcon build --cmake-target doc, then navigate tobuild/ignition-tools2/doxygen/html/and check that the documentation site is correctly generatedcolcon build --cmake-target codecheckand check it passesChecklist
Consider updating Python bindings (if the library has them)codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸