Helper function to get a valid topic name#153
Merged
chapulina merged 2 commits intoign-transport7from Jul 30, 2020
Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-transport7 #153 +/- ##
==================================================
+ Coverage 89.74% 89.75% +0.01%
==================================================
Files 49 49
Lines 4786 4793 +7
==================================================
+ Hits 4295 4302 +7
Misses 491 491
Continue to review full report at Codecov.
|
iche033
reviewed
Jul 28, 2020
Contributor
iche033
left a comment
iche033
left a comment
There was a problem hiding this comment.
looks good to me. Just one minor comment.
Side note, just realized that ign transport topic names are a lot less strict than ROS names. Here's their validate function
Signed-off-by: Louise Poubel <louise@openrobotics.org>
caguero
reviewed
Jul 29, 2020
caguero
approved these changes
Jul 29, 2020
Collaborator
caguero
left a comment
caguero
left a comment
There was a problem hiding this comment.
CI doesn't fully cooperate but all tests passed on my machine. Looks good!
nkoenig
added a commit
that referenced
this pull request
Aug 28, 2020
* Remove warnings using ZMQ 4.3.1 or greater. * Do not use ZMQ_CPP11 * Win debugging. * backport improved compiler support for std::filesystem * Close branch backport_compiler_filesystem * Restore original Playback::Start and add overload with new parameter to fix ABI * bump to 7.2.2 and update changelog * Close branch fix_abi_7 * Write to disk from a background thread in log recorder * Update Changelog * Move `dataWriterState = true` to Recorder::Implementation::DataWriterThread() thread. * Revert moving dataWriterState * Failing test with incorrect time stamps * Correctly record message reception time stamp * Reorder functions * Specify buffer size in MB rather than number of elements in the data queue * Flush any remaining data to log file when stopping the Recorder * Codecheck. The rvalue ref is used to ensure that std::vector is always moved * Version update * Added tag ignition-transport7_7.3.0~pre1 for changeset 173fae6c362d * recorder.cc: include <optional> * Add console message to indicate buffer being flushed * Add <numeric> * Close branch async_recorder * Prepare for 7.3.0 * Added tag ignition-transport7_7.3.0 for changeset 367d4f1bfcf7 * Configurable buffer sizes. * Fix typo. * Changelog. * Clarify high water mark policy. * Tweak documentation and error messages. * Close branch issue_116_transport7 * fix line lengths * Close branch codecheck7 * Update default values for the high water marks * Update buffer default values * Changelog.md edited online with Bitbucket * Close branch default_hwm * Adding connection message. * ConnectionMsg implementation. * Test * No control socket. * Preserve ABI. * Discard registrations when needed. * Tweaks. * Changelog * Fix issue #114. * Close branch discovery_extended_p2 * 7.4.0 * Move changelog entry * Close branch ign-transport7-4 * Added tag ignition-transport7_7.4.0 for changeset 083e7bf41080 * Protobuf warnings * Close branch proto_deprecations * Close branch issue_111 * Windows warnings * revert commit to release branch * Fix version for send_falgs command * Close branch ign-transport7_fix_send_flags * Backport pull request #441 * updates * Added another check * Close branch issue_118 * mv hgignore Signed-off-by: claireyywang <clairewang@openrobotics.org> * add gitignore Signed-off-by: claireyywang <clairewang@openrobotics.org> * [ign-transport7] Update BitBucket links (#123) * [ign-transport7] Update BitBucket links Signed-off-by: Louise Poubel <louise@openrobotics.org> * changelog pull-requests * Apply suggestions from code review * Update tutorials/07_relay.md Co-authored-by: Marya Belanger <marya@openrobotics.org> * [ign-transport7] Workflow updates (#132) * [ign-transport7] Workflow updates Signed-off-by: Louise Poubel <louise@openrobotics.org> * Helper function to get a valid topic name (#153) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Remove Windows warnings (#151) Signed-off-by: Carlos Aguero <caguero@openrobotics.org> * Remove warnings on Homebrew (#150) Signed-off-by: Carlos Aguero <caguero@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Bump to 7.5.0 (#156) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Modernize actions CI (#158) Signed-off-by: Louise Poubel <louise@openrobotics.org> * remove ci-bionic Signed-off-by: Louise Poubel <louise@openrobotics.org> * add focal Signed-off-by: Louise Poubel <louise@openrobotics.org> * msgs5 Signed-off-by: Louise Poubel <louise@openrobotics.org> * Suppress focal-specific warnings (#159) * Suppress focal-specific warnings Signed-off-by: Michael Carroll <michael@openrobotics.org> * Warn when lsb_release isn't present Signed-off-by: Michael Carroll <michael@openrobotics.org> * Adding header guard. Signed-off-by: Carlos Agüero <caguero@openrobotics.org> * Include correct header file for version check Signed-off-by: Michael Carroll <michael@openrobotics.org> * Added more debug output Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix focal test and codecheck Signed-off-by: Nate Koenig <nate@openrobotics.org> * Change endtime expectation Signed-off-by: Carlos Agüero <caguero@openrobotics.org> Co-authored-by: Carlos Agüero <caguero@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Carlos Aguero <caguero@osrfoundation.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@osrfoundation.org> Co-authored-by: Carlos Agüero <cen.aguero@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Nate Koenig <natekoenig@gmail.com> Co-authored-by: Carlos Aguero <caguero@openrobotics.org> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: claireyywang <clairewang@openrobotics.org> Co-authored-by: Marya Belanger <marya@openrobotics.org> Co-authored-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses gazebosim/gz-sim#239
Used by gazebosim/gz-sensors#33
Add a helper function to generate a valid topic name by converting spaces to
_and stripping invalid character combinations.