Fix include/ignition/.../parameters header files#374
Merged
scpeters merged 2 commits intoign-transport11from Dec 8, 2022
Merged
Fix include/ignition/.../parameters header files#374scpeters merged 2 commits intoign-transport11from
scpeters merged 2 commits intoign-transport11from
Conversation
The ignition redirection headers for the parameters component were not installed. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
Codecov Report
@@ Coverage Diff @@
## ign-transport11 #374 +/- ##
================================================
Coverage 88.18% 88.18%
================================================
Files 59 59
Lines 5102 5102
================================================
Hits 4499 4499
Misses 603 603 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
mjcarroll
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes ignition header files for the
parameterscomponent, needed by gazebosim/gz-sim#1431Summary
The ignition redirection headers for the parameters component were not installed; this ensures that they are installed to the proper location and adds some missing redirection files. I noticed this while investigating CI failures for gazebosim/gz-sim#1431.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.