Closed
Conversation
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
caguero
reviewed
Jun 2, 2023
Collaborator
caguero
left a comment
There was a problem hiding this comment.
This works for me. I guess we'll need to merge gz-msgs first and release it, that's why I won't approve yet.
5 tasks
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Member
we don't need to release this; we just need nightly builds |
Member
|
@osrf-jenkins run tests please |
This was referenced Jun 30, 2023
Member
|
I found some other issues in gazebosim/gz-msgs#339 (comment), and I believe they are addressed by the following PRs: Testing with specially-named branches:
|
Member
|
I built a jammy nightly of gz-msgs10 (see gazebo-release/gz-msgs10-release#3 (comment)) and ran the jammy jenkins build for this branch, and it also has some test failures: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates transport to use the message generation framework from gazebosim/gz-msgs#339