Fix compatibility with protobuf 22#405
Merged
scpeters merged 1 commit intogazebosim:ign-transport8from Jun 10, 2023
Merged
Conversation
360e8fe to
a6162eb
Compare
caguero
previously requested changes
Jun 7, 2023
include/gz/transport/RepHandler.hh
Outdated
|
|
||
| #if GOOGLE_PROTOBUF_VERSION > 2999999 | ||
| #if GOOGLE_PROTOBUF_VERSION >= 4022000 | ||
| auto msgReq = |
Collaborator
There was a problem hiding this comment.
Nit: Remove extra space at the end of the line to make the style checker happy.
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
Codecov Report
@@ Coverage Diff @@
## ign-transport8 #405 +/- ##
==================================================
- Coverage 83.61% 83.56% -0.05%
==================================================
Files 51 51
Lines 5035 5039 +4
==================================================
+ Hits 4210 4211 +1
- Misses 825 828 +3
|
This was referenced Jun 9, 2023
scpeters
approved these changes
Jun 10, 2023
scpeters
pushed a commit
that referenced
this pull request
Jun 10, 2023
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
scpeters
pushed a commit
that referenced
this pull request
Jun 15, 2023
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Fix #404 by adding compatibility with protobuf >= 22 .
Summary
Similar to gazebosim/gz-msgs#346, but with an additional fix to change the removed
google::protobuf::down_casttogoogle::protobuf::internal::DownCast. It may not be ideal to use a function declared in aninternal::namepsace, but that how actually the method was called in protobuf 2 when it was first used.Test it
Install protobuf 22 or 23, and compile gz-citadel against it.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.