Open
Conversation
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
quarkytale
reviewed
Apr 22, 2024
Comment on lines
42
to
+43
| mkdir -p ~/template_ws/src | ||
| cd ~/template_ws/src | ||
| wget https://raw.githubusercontent.com/gazebosim/ros_gz_project_template/main/template_workspace.yaml | ||
| vcs import < template_workspace.yaml | ||
| cd ~/template_ws |
Collaborator
There was a problem hiding this comment.
Instead of ~/ do you think <path_to_workspace> would be more clear?
Contributor
Author
There was a problem hiding this comment.
Yes! I don't think we should assume users call it this, or clone in home directory. I certainly don't.
Collaborator
There was a problem hiding this comment.
Do you mind making that change, I couldn't make a suggestion over deleted lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the setup process simpler with less commands and less places to mess up
Checklist
codecheckpassed (See contributing)🎈 Release
Preparation for <X.Y.Z> release.
Comparison to <x.y.z>: https://github.com/gazebosim//compare/<LATEST_TAG_BRANCH>...<RELEASE_BRANCH>
Needed by <PR(s)>
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.