Change the logic to save the code status leaving the user the ability to set the command#1032
Merged
GiulioRomualdi merged 2 commits intomasterfrom Apr 7, 2026
Merged
Change the logic to save the code status leaving the user the ability to set the command#1032GiulioRomualdi merged 2 commits intomasterfrom
GiulioRomualdi merged 2 commits intomasterfrom
Conversation
GiulioRomualdi
force-pushed
the
code_status_command
branch
from
1c266ab to
ec1347e
Compare
S-Dafarra
reviewed
Apr 7, 2026
| <param name="port_prefix">/yarp-robot-logger</param> | ||
| <param name="log_text">true</param> | ||
| <param name="text_logging_subnames">("ergoCubGazeboV1/yarprobotinterface")</param> | ||
| <param name="log_code_status">true</param> |
Collaborator
There was a problem hiding this comment.
I think that this flag has been removed by mistake since the code to read it is still there. In general, I would prefer to keep it anyhow to facilitate the enabling/disabling of this functionality
Collaborator
Author
There was a problem hiding this comment.
yes my fault! Let me add it again !
traversaro
approved these changes
Apr 7, 2026
Collaborator
|
Ok no sorry, I did not noticed that there was auto-merge enabled, so my review effectively merged the PR, my bad. I think @S-Dafarra point is valid. |
Collaborator
Author
|
Don't worry @traversaro I open a new PR |
Collaborator
It could be directly #1034 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gives teh final user the possibility to write the command to store the code status instead of hardcode the superbuild command.
This is usefull in case the repo is not installed via the superbuild (e.g., via conda)