Fix private model import logic #3032
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PE39806
added
bug
GB907762
previously approved these changes
Dec 16, 2025
ON93754
reviewed
Dec 18, 2025
ON93754
reviewed
Dec 18, 2025
IR96334
reviewed
Dec 18, 2025
| export async function getModelByIdNoAuth(modelId: string, kind?: EntryKindKeys): Promise<ModelDoc> { | ||
| const model = await ModelModel.findOne({ | ||
| id: modelId, | ||
| ...(kind && { kind }), |
Contributor
Author
There was a problem hiding this comment.
Yes - this is used by the getModel endpoint https://github.com/gchq/Bailo/blob/main/backend/src/routes/v2/model/getModel.ts
Member
There was a problem hiding this comment.
Ah, I see. As "ModelModel" is really EntryModel. I assume there is a condition in which two entries could have same id, but different kind to distinguish them? If not, and no two entries can have the same id, do we need kind for searching the "models"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.