6138 - Spark client #6137
Open
6138 - Spark client #6137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patchwork01
added
the
needs-reviewer
patchwork01
reviewed
Dec 11, 2025
| </parent> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <artifactId>spark</artifactId> |
Collaborator
There was a problem hiding this comment.
Would it be worth making a parent module for clients? We could put both this and the current clients module under that. The naming might be awkward, I suppose it could be client/spark-client and client/clients.
Member
Author
There was a problem hiding this comment.
I propose we leave it as it is in this PR but later move this, the Athena and Trino code to one parent module: #6251
patchwork01
reviewed
Dec 15, 2025
m09526
requested changes
Dec 16, 2025
java/spark/src/main/java/sleeper/spark/SleeperRowPartitionReader.java
Outdated
Show resolved
Hide resolved
m09526
requested changes
Dec 17, 2025
java/spark/src/main/java/sleeper/spark/SleeperColumnarBatchPartitionReader.java
Outdated
Show resolved
Hide resolved
patchwork01
removed
the
needs-reviewer
patchwork01
added
the
needs-reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Issue
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
Tests
Documentation
separate issue for that below.