Skip to content

Enhancement: Add storybook#69

Merged
gcoro merged 4 commits into
gcoro:masterfrom
PedroMarianoAlmeida:feature/pupilStyle
Jan 22, 2026
Merged

Enhancement: Add storybook#69
gcoro merged 4 commits into
gcoro:masterfrom
PedroMarianoAlmeida:feature/pupilStyle

Conversation

@PedroMarianoAlmeida

@PedroMarianoAlmeida PedroMarianoAlmeida commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

This PR implements Storybook for development purposes

I take special attention to inner, outer eye properties, those are the stories specific to that:
Screenshot 2026-01-22 at 16 25 07

Screenshot 2026-01-22 at 16 25 13 Screenshot 2026-01-22 at 16 25 20

@gcoro

gcoro commented Jan 18, 2026

Copy link
Copy Markdown
Owner

hi, thank you for your PR,
i think it's already possible to control the eyes in the way you described using the current props, by specifying different arrays for inner and outer in the eyeRadius prop, like in the last example here.
let me know if i'm missing something or your library behaves differently

@PedroMarianoAlmeida

Copy link
Copy Markdown
Contributor Author

Hi!
Yes, you are right... No need to change the API with an extra prop. Thanks for showing me the right example!

How about the Storybook? Do you want to keep it, or should I just close the PR? (I can keep only the Storybook changes if you want)

@gcoro

gcoro commented Jan 22, 2026

Copy link
Copy Markdown
Owner

the storybook looks good to me! i can merge it if you also fix the parts that reference the new prop :) ty

@PedroMarianoAlmeida PedroMarianoAlmeida changed the title Feature/pupil style Enhancement: Add storybook Jan 22, 2026
@PedroMarianoAlmeida

Copy link
Copy Markdown
Contributor Author

Done! Do you want more story examples?

@gcoro gcoro self-requested a review January 22, 2026 20:28

@gcoro gcoro left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's okay! thanks 🙏

@gcoro gcoro merged commit d40abb6 into gcoro:master Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants