Skip to content

refactor(pallet-gear-builtin) builtin ids can now be read by subscan #4771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

refactor(pallet-gear-builtin) builtin ids can now be read by subscan #4771

wants to merge 13 commits into from

Conversation

Lazark0x
Copy link
Member

Resolves #4694

Lazark0x added 3 commits July 16, 2025 15:53
@Lazark0x
initial
852d7a2
@Lazark0x
Merge remote-tracking branch 'origin/master' into laz/4694-builtin-id…
f1b9f80 
…s-as-pallet-ids

# Conflicts:
#	examples/proxy-broker/src/wasm.rs
#	pallets/gear-builtin/src/lib.rs
#	pallets/gear-builtin/src/mock.rs
#	pallets/gear-builtin/src/tests/bad_builtin_ids.rs
#	pallets/gear-builtin/src/tests/staking.rs
#	runtime/vara/Cargo.toml
#	runtime/vara/src/lib.rs
@Lazark0x
reformat
a32a2ac
@Lazark0x Lazark0x self-assigned this Jul 16, 2025
@Lazark0x Lazark0x added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Jul 16, 2025
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jul 16, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  pallets/gear/src/tests.rs  73% smaller
  runtime/vara/src/tests/mod.rs  55% smaller
  pallets/gear-eth-bridge/src/builtin.rs  55% smaller
  examples/staking-broker/src/wasm.rs  42% smaller
  examples/proxy-broker/src/wasm.rs  29% smaller
  pallets/gear-builtin/rpc/runtime-api/src/lib.rs  24% smaller
  pallets/gear-builtin/src/lib.rs  22% smaller
  runtime/vara/src/lib.rs  22% smaller
  common/src/lib.rs  21% smaller
  pallets/gear-builtin/src/tests/bad_builtin_ids.rs  20% smaller
  examples/bls381/src/wasm.rs  16% smaller
  pallets/gear-eth-bridge/src/mock.rs  11% smaller
  pallets/gear-builtin/rpc/src/lib.rs  8% smaller
  pallets/gear-builtin/src/tests/bls381.rs  7% smaller
  pallets/gear-builtin/src/tests/staking.rs  6% smaller
  pallets/gear-builtin/src/tests/basic.rs  5% smaller
  pallets/gear-builtin/src/mock.rs  2% smaller
  Cargo.lock Unsupported file format
  examples/bls381/Cargo.toml Unsupported file format
  examples/staking-broker/Cargo.toml Unsupported file format
  node/service/Cargo.toml Unsupported file format
  pallets/gear-builtin/Cargo.toml Unsupported file format
  pallets/gear-builtin/rpc/Cargo.toml Unsupported file format
  pallets/gear-builtin/rpc/runtime-api/Cargo.toml Unsupported file format
  pallets/gear-builtin/src/benchmarking.rs  0% smaller
  pallets/gear-builtin/src/bls12_381.rs  0% smaller
  pallets/gear-builtin/src/proxy.rs  0% smaller
  pallets/gear-builtin/src/staking.rs  0% smaller
  pallets/gear-eth-bridge/Cargo.toml Unsupported file format
  pallets/gear-eth-bridge/src/lib.rs  0% smaller
  runtime/vara/Cargo.toml Unsupported file format

@Lazark0x Lazark0x requested a review from breathx July 21, 2025 10:11
@Lazark0x Lazark0x added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Jul 21, 2025
Lazark0x and others added 6 commits July 21, 2025 12:12
@Lazark0x
Merge branch 'master' into laz/4694-builtin-ids-as-pallet-ids
134f835
@Lazark0x
removed dependencies
9765803
@Lazark0x
Merge remote-tracking branch 'origin/master' into laz/4694-builtin-id…
11cb1e9 
…s-as-pallet-ids
@Lazark0x
qf
7d4d991
@Lazark0x
Merge remote-tracking branch 'origin/master' into laz/4694-builtin-id…
b1e6ef4 
…s-as-pallet-ids

# Conflicts:
#	pallets/gear-builtin/src/mock.rs
#	pallets/gear-builtin/src/tests/bad_builtin_ids.rs
#	pallets/gear-eth-bridge/src/builtin.rs
@Lazark0x
Merge remote-tracking branch 'origin/master' into laz/4694-builtin-id…
9937f14 
…s-as-pallet-ids

# Conflicts:
#	pallets/gear-builtin/src/tests/basic.rs
#	pallets/gear-builtin/src/tests/staking.rs
techraed
techraed reviewed Aug 27, 2025
View reviewed changes
pallets/gear-builtin/src/lib.rs

#[derive(Clone, Copy, Default, Eq, PartialEq, TypeInfo)]
#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
pub struct BuiltinActorId {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about moving this stuff along with BuiltinActorType to the gbuiltins?
Ids are demanded by sails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techraed techraed techraed left review comments

@breathx breathx Awaiting requested review from breathx

At least 1 approving review is required to merge this pull request.

Assignees

@Lazark0x Lazark0x

Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider(pallet-gear-builtin): option to derive builtin ids the same as pallet ids
2 participants
@Lazark0x @techraed