feat(`ethexe-consensus`): implement changing validator set for the next era #4847

ecol-master · 2025-09-09T17:10:53Z

semanticdiff-com · 2025-09-09T17:10:56Z

Review changes with

Changed Files

File	Status
ethexe/ethereum/WrappedVara.json	100% smaller
ethexe/consensus/src/validator/subordinate.rs	90% smaller
ethexe/consensus/src/validator/coordinator.rs	76% smaller
ethexe/ethereum/src/middleware/mod.rs	73% smaller
ethexe/processor/src/handling/events.rs	71% smaller
ethexe/consensus/src/validator/initial.rs	68% smaller
ethexe/service/src/tests/utils/env.rs	51% smaller
ethexe/consensus/src/validator/mod.rs	48% smaller
ethexe/consensus/src/validator/producer.rs	47% smaller
ethexe/ethereum/src/lib.rs	44% smaller
ethexe/consensus/src/validator/mock.rs	38% smaller
ethexe/db/src/database.rs	37% smaller
ethexe/ethereum/src/router/mod.rs	35% smaller
ethexe/observer/src/sync.rs	31% smaller
ethexe/observer/src/lib.rs	28% smaller
ethexe/common/src/db.rs	28% smaller
ethexe/consensus/src/validator/core.rs	25% smaller
ethexe/consensus/src/utils.rs	5% smaller
ethexe/ethereum/src/deploy.rs	4% smaller
ethexe/compute/src/prepare.rs	1% smaller
ethexe/common/src/primitives.rs	1% smaller
ethexe/service/src/tests/mod.rs	1% smaller
Cargo.lock	Unsupported file format
Cargo.toml	Unsupported file format
ethexe/common/src/crypto/address.rs	0% smaller
ethexe/common/src/events/router.rs	0% smaller
ethexe/common/src/utils.rs	0% smaller
ethexe/compute/src/service.rs	0% smaller
ethexe/compute/src/tests.rs	0% smaller
ethexe/consensus/Cargo.toml	Unsupported file format
ethexe/consensus/src/validator/submitter.rs	0% smaller
ethexe/contracts/src/IRouter.sol	Unsupported file format
ethexe/contracts/src/Router.sol	Unsupported file format
ethexe/db/Cargo.toml	Unsupported file format
ethexe/ethereum/Middleware.json	Unsupported file format
ethexe/ethereum/Mirror.json	Unsupported file format
ethexe/ethereum/Router.json	Unsupported file format
ethexe/ethereum/src/abi/events/router.rs	0% smaller
ethexe/ethereum/src/abi/mod.rs	0% smaller
ethexe/observer/Cargo.toml	Unsupported file format
ethexe/processor/src/lib.rs	0% smaller
ethexe/service/src/fast_sync.rs	Unsupported file format
ethexe/service/src/tests/utils/mod.rs	0% smaller
ethexe/service/src/tests/utils/symbiotic.rs	0% smaller

…-validators

…ators-support-in-validators

ethexe/common/src/primitives.rs

ethexe/compute/src/prepare.rs

Cargo.toml

ethexe/service/src/tests/utils/env.rs

ethexe/processor/src/handling/events.rs

ethexe/contracts/src/libraries/Gear.sol

ethexe/service/src/tests/mod.rs

ecol-master · 2025-09-12T14:21:52Z

ethexe/service/src/tests/mod.rs

 }
+
+// #[tokio::test(flavor = "multi_thread")]
+// #[ntest::timeout(60_000)]


TODO impl test for validators commitment

ethexe/consensus/src/validator/producer.rs

…-validators

grishasobol · 2025-09-15T11:25:29Z

Cargo.toml


 # there are patches to disable `memory.grow` and to add offset of reserved memory
-wasm-smith = { version = "0.230", git = "https://github.com/gear-tech/wasm-tools", branch = "gear-stable-1.230" }
+wasm-smith = { version = "0.230", git = "https://github.com/gear-tech/wasm-tools", branch = "gear-stable-1.230" }


grishasobol · 2025-09-15T11:30:08Z

ethexe/common/src/crypto/address.rs

+#[debug("ValidatorsVec must be non-empty")]
+pub struct TryFromVecError;
+
+// Usefull conversions from / to `Vec<Address>`


grishasobol · 2025-09-15T11:30:56Z

ethexe/common/src/crypto/address.rs

+
+#[derive(Debug, Display, Error)]
+#[display("{:?}", self)]
+#[debug("ValidatorsVec must be non-empty")]


Suggested change

#[debug("ValidatorsVec must be non-empty")]

#[debug("Vec must be non-empty")]

grishasobol · 2025-09-15T11:50:38Z

ethexe/processor/src/handling/events.rs


                self.transitions.register_new(actor_id);
            }
+            RouterRequestEvent::NextEraValidatorsCommitted { era_index } => {


Processor is not responsible for this kind of events

Move it to observer

grishasobol · 2025-09-15T14:08:21Z

ethexe/observer/src/sync.rs

+        let timelines = self
+            .db
+            .gear_exe_timelines()
+            .ok_or(anyhow!("not fonud gear exe timelines in db"))?;


Suggested change

.ok_or(anyhow!("not fonud gear exe timelines in db"))?;

.ok_or(anyhow!("not found gear exe timelines in db"))?;

grishasobol · 2025-09-15T14:12:07Z

ethexe/observer/src/sync.rs


        self.mark_chain_as_synced(chain.into_iter().rev());
-        self.propagate_validators(block, header).await?;
+        self.propagate_validators_info(block, &header).await?;


propagate_validators_info must be done before mark_chain_as_synced

grishasobol · 2025-09-15T14:27:46Z

ethexe/common/src/primitives.rs

+/// The state switches to [`NextEraValidators::Elected`] at the election checkpoint by calling `makeElectionAt` in the middleware.
+/// After the commitment is included in a block, the state switches to [`NextEraValidators::Committed`].
+#[derive(Debug, Clone, Default, PartialEq, Eq, Encode, Decode)]
+pub enum NextEraValidators {


I don't like idea of storing next era validators in DB. Why:

Observer must make election - this is ok right now, but should be moved to consensus service in future (consensus call rpc by self)

Elected, but not committed validators could be stored in consensus service memory, which is much simpler implementation

In propagate_validators_info - is the only one case where you use it. It removes rpc access once per era, but increase code complexity all over gear exe code, I don't think is fare trade

grishasobol · 2025-09-15T14:28:05Z

ethexe/common/src/db.rs

+/// Static data stored in the database.
+/// Expected to be unmutable and set only once.
+#[derive(Debug, Clone, Copy, Default, PartialEq, Eq, Encode, Decode)]
+pub struct StaticData {


Use LatestData

…-validators

…a-validators-support-in-validators

…-validators

validators info | save next era validators

b73c2b9

ecol-master linked an issue Sep 9, 2025 that may be closed by this pull request

ethexe: next era validators support in gear.exe #4382

Open

Dmitry Kuzmin and others added 6 commits September 10, 2025 23:38

dirty impl

5dacb53

unused deps

edbb71f

Merge branch 'master' into 4382-ethexe-next-era-validators-support-in…

e394146

…-validators

new validators vec

d17ddcb

implement main logic

9b808e7

Merge remote-tracking branch 'origin' into 4382-ethexe-next-era-valid…

b3726f6

…ators-support-in-validators

ecol-master force-pushed the 4382-ethexe-next-era-validators-support-in-validators branch from 908490a to b3726f6 Compare September 12, 2025 14:04

ecol-master commented Sep 12, 2025

View reviewed changes

ecol-master self-assigned this Sep 12, 2025

ecol-master added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed Q4-epic D8-gearexe gear.exe-related PR labels Sep 12, 2025

ecol-master changed the title ~~feat(ethexe): Producer validators commitment~~ feat(ethexe-consensus): implement logic to change validator set for the next era Sep 14, 2025

Dmitry Kuzmin and others added 3 commits September 15, 2025 10:38

fix self-review

6d295fa

Merge branch 'master' into 4382-ethexe-next-era-validators-support-in…

3e97eb0

…-validators

Merge branch 'master' into 4382-ethexe-next-era-validators-support-in…

335d274

…-validators

grishasobol self-requested a review September 15, 2025 11:27

grishasobol requested changes Sep 15, 2025

View reviewed changes

ecol-master changed the title ~~feat(ethexe-consensus): implement logic to change validator set for the next era~~ feat(ethexe-consensus): implement changing validator set for the next era Sep 17, 2025

Dmitry Kuzmin and others added 8 commits September 17, 2025 08:36

Merge branch 'master' into 4382-ethexe-next-era-validators-support-in…

155e794

…-validators

start introducing new state for producer

96e2a3b

initial

f6a8560

add file core

7f4d487

small fixes

14e6724

Merge branch 'master' into gsobol/ethexe/consensus-async

9d0c4a3

commit before gsobol/async-fix

b11d624

Merge branch 'gsobol/ethexe/consensus-async' into 4382-ethexe-next-er…

549c71d

…a-validators-support-in-validators

Dmitry Kuzmin added 3 commits September 23, 2025 15:09

small refactoring MiddlewareWrapper

329c156

before merge

1afd3da

Merge branch 'master' into 4382-ethexe-next-era-validators-support-in…

32e7617

…-validators

	#[debug("ValidatorsVec must be non-empty")]
	#[debug("Vec must be non-empty")]

	.ok_or(anyhow!("not fonud gear exe timelines in db"))?;
	.ok_or(anyhow!("not found gear exe timelines in db"))?;

feat(ethexe-consensus): implement changing validator set for the next era #4847

Are you sure you want to change the base?

feat(ethexe-consensus): implement changing validator set for the next era #4847

Uh oh!

Conversation

ecol-master commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

semanticdiff-com bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

feat(`ethexe-consensus`): implement changing validator set for the next era #4847

feat(`ethexe-consensus`): implement changing validator set for the next era #4847

ecol-master commented Sep 9, 2025 •

edited

Loading

semanticdiff-com bot commented Sep 9, 2025 •

edited

Loading