chore: begin replacement of Make and ./scripts/gear.sh with Just
#4862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
breathx
approved these changes
Sep 23, 2025
|
|
||
| - name: "Check clippy" | ||
| run: ./scripts/gear.sh clippy gear --all-targets --all-features --locked | ||
| run: just clippy native |
There was a problem hiding this comment.
its more likely
just clippy :: { workspace ; examples } -> not the point that its wasms
but moreover these steps could be merged into one
| - name: "Install: Cargo extensions" | ||
| uses: ./.github/actions/install-cargo-extensions | ||
|
|
||
| - name: "Show: Versioning" |
There was a problem hiding this comment.
such simple commands could be nameless in CI
There was a problem hiding this comment.
Other such commands, like "Install: Rust toolchain" or "Install: Foundry" are not nameless.
ark0f
requested changes
Sep 27, 2025
There was a problem hiding this comment.
|
|
||
| # Remove untracked files and build caches | ||
| [group('actions')] | ||
| [confirm('Remove all untracked files and build caches? (y/n)')] |
There was a problem hiding this comment.
Build caches (target dir) are not cleaned
There was a problem hiding this comment.
Target directory is a part of .gitignore so is fully removed by git clean -fdx.
There was a problem hiding this comment.
require() may simplify script
Comment on lines
+29
to
+37
| # Format code via `rustfmt` | ||
| [group('actions')] | ||
| fmt: | ||
| cargo fmt --all | ||
|
|
||
| # Check formatting with `rustfmt` | ||
| [group('checks')] | ||
| fmt-check: | ||
| cargo fmt --all --check |
There was a problem hiding this comment.
Suggested change
| # Format code via `rustfmt` | |
| [group('actions')] | |
| fmt: | |
| cargo fmt --all | |
| # Check formatting with `rustfmt` | |
| [group('checks')] | |
| fmt-check: | |
| cargo fmt --all --check | |
| # Format code via `rustfmt` | |
| [group('actions')] | |
| fmt *ARGS: | |
| cargo fmt --all {{ARGS}} |
|
|
||
| # Check code with `cargo check` | ||
| [group('checks')] | ||
| check: |
There was a problem hiding this comment.
Can be removed. We always use clippy
Comment on lines
+79
to
+84
| [group('checks')] | ||
| test-doc: | ||
| # Running documentation tests | ||
| __GEAR_WASM_BUILDER_NO_BUILD=1 \ | ||
| SKIP_WASM_BUILD=1 \ | ||
| cargo test --doc --workspace --no-fail-fast |
There was a problem hiding this comment.
Suggested change
| [group('checks')] | |
| test-doc: | |
| # Running documentation tests | |
| __GEAR_WASM_BUILDER_NO_BUILD=1 \ | |
| SKIP_WASM_BUILD=1 \ | |
| cargo test --doc --workspace --no-fail-fast | |
| [group('checks')] | |
| test-doc $__GEAR_WASM_BUILDER_NO_BUILD="1" $SKIP_WASM_BUILD="1": | |
| cargo test --doc --workspace --no-fail-fast |
Comment on lines
+62
to
+76
| test: (ensure-cargo "hack") (ensure-cargo "nextest") | ||
| # Running workspace tests | ||
| cargo nextest run \ | ||
| --workspace \ | ||
| --no-fail-fast \ | ||
| --exclude gclient \ | ||
| --exclude gcli \ | ||
| --exclude gsdk \ | ||
| --exclude gear-authorship \ | ||
| --exclude pallet-gear-staking-rewards \ | ||
| --exclude gear-wasm-gen \ | ||
| --exclude demo-stack-allocations \ | ||
| --exclude gring \ | ||
| --exclude runtime-fuzzer \ | ||
| --exclude runtime-fuzzer-fuzz |
There was a problem hiding this comment.
Suggested change
| test: (ensure-cargo "hack") (ensure-cargo "nextest") | |
| # Running workspace tests | |
| cargo nextest run \ | |
| --workspace \ | |
| --no-fail-fast \ | |
| --exclude gclient \ | |
| --exclude gcli \ | |
| --exclude gsdk \ | |
| --exclude gear-authorship \ | |
| --exclude pallet-gear-staking-rewards \ | |
| --exclude gear-wasm-gen \ | |
| --exclude demo-stack-allocations \ | |
| --exclude gring \ | |
| --exclude runtime-fuzzer \ | |
| --exclude runtime-fuzzer-fuzz | |
| test *ARGS: (ensure-cargo "hack") (ensure-cargo "nextest") | |
| # Running workspace tests | |
| cargo nextest run --workspace --all-targets --all-features -E 'not package(/fuzz/)' {{ARGS}} |
Comment on lines
+88
to
+95
| [group('checks')] | ||
| check-runtime-imports: | ||
| # Checking runtime imports | ||
| cargo build -p wasm-proc | ||
| cargo build -p vara-runtime | ||
| ./target/debug/wasm-proc \ | ||
| --check-runtime-imports \ | ||
| target/debug/wbuild/vara-runtime/vara_runtime.wasm |
There was a problem hiding this comment.
Suggested change
| [group('checks')] | |
| check-runtime-imports: | |
| # Checking runtime imports | |
| cargo build -p wasm-proc | |
| cargo build -p vara-runtime | |
| ./target/debug/wasm-proc \ | |
| --check-runtime-imports \ | |
| target/debug/wbuild/vara-runtime/vara_runtime.wasm | |
| [group('checks')] | |
| check-runtime-imports: | |
| # Checking runtime imports | |
| cargo build -p vara-runtime | |
| cargo run -p wasm-proc -- \ | |
| --check-runtime-imports \ | |
| target/debug/wbuild/vara-runtime/vara_runtime.wasm |
| # Check all WASM code | ||
| wasm: | ||
| # Checking all WASM code with Clippy | ||
| cargo metadata --no-deps --format-version=1 \ |
There was a problem hiding this comment.
Consider to use shebang scripts and paste lines directly from ./scripts/src/clippy.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
justfileas an alternative to existingMakefileand./scripts/gear.sh../scripts/gear.shwith usage of Just in some parts of CI../scrpts/gear.shin CI where there's no need for abstraction into a script.