fix: add missing semicolon to make Ubuntu unattended updates work again

[conFrituur]

Adding the semicolon made unattended security upgrades work again on Ubuntu 🙂

Only tested on Ubuntu Noble (24.04), not Debian.

[bahoop]

1. I can confirm this for ubuntu. manual tested on proxmox lxc with ubuntu-24.04-standard_24.04-2_amd64.tar.zst template.

2. I also did the test manual on debian 13 lxc with debian-13-standard_13.1-2_amd64.tar.zst

command apt-config dump Unattended-Upgrade::Origins-Pattern results in

Without semicolon (broken):

root@lxc:/home/bahoop# apt-config dump Unattended-Upgrade::Origins-Pattern
Unattended-Upgrade::Origins-Pattern "";
Unattended-Upgrade::Origins-Pattern:: "origin=Debian,codename=${distro_codename},label=Debian-Security";
Unattended-Upgrade::Origins-Pattern:: "origin=Debian,codename=${distro_codename}-security,label=Debian-Security";
Unattended-Upgrade::Origins-Pattern::origin%3dUbuntu,archive%3d${distro_codename}-security "origin=${distro_id}ESMApps,archive=${distro_codename}-apps-security";
Unattended-Upgrade::Origins-Pattern:: "origin=${distro_id}ESM,archive=${distro_codename}-infra-security";

With semicolon (fixed):

root@lxc:/home/bahoop# apt-config dump Unattended-Upgrade::Origins-Pattern
Unattended-Upgrade::Origins-Pattern "";
Unattended-Upgrade::Origins-Pattern:: "origin=Debian,codename=${distro_codename},label=Debian-Security";
Unattended-Upgrade::Origins-Pattern:: "origin=Debian,codename=${distro_codename}-security,label=Debian-Security";
Unattended-Upgrade::Origins-Pattern:: "origin=Ubuntu,archive=${distro_codename}-security";
Unattended-Upgrade::Origins-Pattern:: "origin=${distro_id}ESMApps,archive=${distro_codename}-apps-security";
Unattended-Upgrade::Origins-Pattern:: "origin=${distro_id}ESM,archive=${distro_codename}-infra-security";

command unattended-upgrades --dry-run --debug results in

Without semicolon (origin=Ubuntu,archive=trixie-security not present):

Allowed origins are: origin=Debian,codename=trixie,label=Debian-Security, origin=Debian,codename=trixie-security,label=Debian-Security, origin=DebianESMApps,archive=trixie-apps-security, origin=DebianESM,archive=trixie-infra-security

With semicolon (origin=Ubuntu,archive=trixie-security present)
Allowed origins are: origin=Debian,codename=trixie,label=Debian-Security, origin=Debian,codename=trixie-security,label=Debian-Security, origin=Ubuntu,archive=trixie-security, origin=DebianESMApps,archive=trixie-apps-security, origin=DebianESM,archive=trixie-infra-security

origin=Ubuntu,archive=trixie-security should have no effect on debian but I think it won't break something.

[benjamin-dk]

I can confirm this issue and that adding the missing semicolon fixes it. Ubuntu 24.04.