Make sleep timer use a GLib timeout to avoid issues with sleeping after the end of a chapter#1011
Open
stevenleadbeater wants to merge 9 commits intogeigi:masterfrom
Open
Make sleep timer use a GLib timeout to avoid issues with sleeping after the end of a chapter#1011stevenleadbeater wants to merge 9 commits intogeigi:masterfrom
stevenleadbeater wants to merge 9 commits intogeigi:masterfrom
Conversation
…er the end of a chapter
… always show, and when the user confirms deletion, it will check if files exist before trying to delete them. The book will be removed from the library regardless. 2. Popup display on phones: The dialog now always shows when attempting to delete a book, instead of silently removing it when files don't exist. This ensures consistent behavior across all devices including phones. The changes ensure that: - The delete confirmation dialog always appears when trying to delete a book - Books are properly removed from the library even if their files are already gone - File deletion is only attempted if the files actually exist
# Conflicts: # .github/workflows/flatpak.yml # com.github.geigi.cozy.json
Collaborator
Author
Actually having the timer continue when the book is paused is kind of normal for an audiobook player, if I can't sleep and go down stairs to make a drink or something then come back and unpause, other apps usually carry the sleep timer on... can't say for definite which but it kind of feels natural to me? this is kind of airy fairy stuff though, I can see why cancelling the timer might be preferred too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.