Skip to content

[Backport] Fixed set template syntax issue #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2018

Conversation

gelanivishal
Copy link
Owner

Original Pull Request

magento#15398

Description

I have added module name on a template file as per Magento standard coding format.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

I have changed all Magneto Backend module template. so You can check after login on Magento Dashboard.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal merged commit 9400075 into 2.1-develop May 25, 2018
gelanivishal pushed a commit that referenced this pull request Jun 7, 2018
 - Merge Pull Request magento#15805 from chirag-wagento/magento2:2.1-develop-PR-port-15790
 - Merged commits:
   1. b01558a
gelanivishal pushed a commit that referenced this pull request Jun 7, 2018
Accepted Public Pull Requests:
 - magento#15725: [Backport] Updated font-size variable and standardize #ToDo UI (by @vgelani)
 - magento#15724: [Backport] Moved css from media #TODO (by @vgelani)
 - magento#15736: [Backwardport] Refactor javascript code of  button split widget (by @vijay-wagento)
 - magento#15739: [Backport] fix: support multiple minisearch widget instances (by @vijay-wagento)
 - magento#15719: [Backport 2.1] Fixed return type of wishlist's getImageData in DocBlock (by @rogyar)
 - magento#15716: [BACKPORT 2.1 magento#15695] Fixed a couple of typos (by @dverkade)
 - magento#15803: [Backport] Remove double semicolon from the style sheets. (by @vijay-wagento)
 - magento#15807: [Backport] [Code improvement] (by @hitesh-wagento)
 - magento#15810: [Backport] fix: support multiple minisearch widget instances (by @DanielRuf)
 - magento#15805: [Backport] Make necessary space. #5 (by @chirag-wagento)


Fixed GitHub Issues:
 - magento#15354: Refactor javascript code of button split widget call js component (reported by @amittiwari024) has been fixed in magento#15736 by @vijay-wagento in 2.1-develop branch
   Related commits:
     1. 02453f6
gelanivishal pushed a commit that referenced this pull request Jun 19, 2018
gelanivishal pushed a commit that referenced this pull request Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant