quickpkg: enable include-unmodified-config by default #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floppym
force-pushed
the
bug939896-include-unmodified-config
branch
from
5b78343 to
f649b64
Compare
If the user has not modified an installed config file, there should be no risk of exposing secret information by including the file. This makes quickpkg behave more reasonably with FEATURES="config-protect-if-modified", which has been enabled by default since 304dfb0. Bug: https://bugs.gentoo.org/939896 Signed-off-by: Mike Gilbert <[email protected]>
floppym
force-pushed
the
bug939896-include-unmodified-config
branch
from
80d4f0b to
f0d68bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has not modified an installed config file, there should be no risk of exposing secret information by including the file.
This makes quickpkg behave more reasonably with
FEATURES="config-protect-if-modified", which has been enabled by default since 304dfb0.
Bug: https://bugs.gentoo.org/939896