Save KML for offline use #2084
Save KML for offline use #2084
Conversation
oterral
force-pushed
the
teo_kml_offline
branch
from
789a286 to
021f6e3
Compare
|
Nice !! and tough mtb test ! |
|
No worry
We'll get this fine! |
oterral
force-pushed
the
teo_kml_offline
branch
from
021f6e3 to
f0662a0
Compare
|
good for review
|
| @@ -395,6 +420,18 @@ | |||
| var layer = layers[i]; | |||
| layersIds.push(layer.id); | |||
| layersOpacity.push(layer.invertedOpacity); | |||
|
|
|||
| // if the layer is a KML | |||
| if (gaKml.isKmlLayer(layer) && /http/.test(layer.url)) { | |||
There was a problem hiding this comment.
Would make sense to also check for https here.
There was a problem hiding this comment.
httpis include inhttps but I can improve a bit the regex to be sure.
There was a problem hiding this comment.
dummy, of course. Improvement might still be a good idea. Can we use ^ and :// ?
|
KML Drawing Saving is broken |
|
@ponceta you're insane !!!!! it's only for imported KML.;) . You can draw then import and then save :) Update: misunderstanding what you want. Good catch i try to fix this. |
oterral
force-pushed
the
teo_kml_offline
branch
from
f0662a0 to
54c2d4c
Compare
|
<3 sorry for catching bugs ;) |
oterral
force-pushed
the
teo_kml_offline
branch
4 times, most recently
from
ddb1819 to
0c319f2
Compare
|
Good for final review/test |
| if (!kmlString) { | ||
| kmlString = new XMLSerializer().serializeToString(node); | ||
| } | ||
| kmlString = new ol.format.KML().writeFeatures(exportFeatures); |
There was a problem hiding this comment.
Does ol3 now take care of this?
There was a problem hiding this comment.
Yes OL3 returns a string now
|
Code looks very good. Just a small thing: when loading the kml in off-line mode, I don't get the start and end symbols (I get the track). Am I doing something wrong or is this problematic? |
|
Ok, it's normal (icons are from extern and we don't safe those). |
oterral
force-pushed
the
teo_kml_offline
branch
from
0c319f2 to
d878847
Compare
Fix #1839 #1647
Wait for openlayers/openlayers#3128
Test
Missing some tests and translations